Improve threading behavior #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New model schedules jobs quickly but executes them on low priority so that we can combine updates if the UI starts falling behind. program.UpdateViewModel(vm, model) is fully transitive so it's safe to skip intermediate updates as long as we get the last one.
This was referenced Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a caching feature for setters which allows us to notify property changed within the setter rather than waiting for UpdateModel to be called (which is more idiomatic within MVVM).
With this in play, the threaded behavior no longer has to block on potentially expensive ViewModel Updates in order to guarantee well-behaved TwoWay bindings on TextBoxes. Instead, we can schedule ViewModel Updates so that they "drop" intermediate Updates when they start piling up. This is possible because ViewModel Updates are fundamentally transitive with MVU. So for example,
vm.Update(model1); vm.Update(model2); vm.Update(model3);always results in the same final view state asvm.Update(model1); vm.Update(model3);This latter behavior only applies to Elmish in multithreaded mode. It does not change the normal singlethreaded behavior at all.